feat: add tab switch to hide pages and sidebar #560
Conversation
|
I don't see the necessity for the underline to highlight the active icon in addition to the color |
|
It makes more sense when this pattern is used on the right side as a sidebar switch to switch between Properties and Project Settings, doesn’t it?
|
|
Also, if there are options to toggle pages and the elementpane, there should also be an option to hide the property pane |
|
@tilmx if it's used as an actual tab I agree, but if it's used as an checkbox I'd disagree. |
|
I removed it. |
| import styled from 'styled-components'; | ||
|
|
||
| export interface TabSwitchProps { | ||
| active?: boolean; |
There was a problem hiding this comment.
Let's use an required enum instead:
enum TabSwitchState {
Active,
Default
}
src/electron/main.ts
Outdated
| @@ -508,7 +507,7 @@ async function createWindow(): Promise<void> { | |||
| minWidth: 780, | |||
| minHeight: 380, | |||
| titleBarStyle: 'hiddenInset', | |||
| backgroundColor: Color.Grey97, | |||
| backgroundColor: '#f7f7f7', | |||
There was a problem hiding this comment.
Some special reason for this one?
There was a problem hiding this comment.
Color.Grey97 didn’t work (I guess because electron only allows hex values)
There was a problem hiding this comment.
Ah, so lets use the color module here to convert from rgb to hex then.
Add a tab switch to hide both the pages or the elements & library: