Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kerncrash current glyph error on G3. #217

Open
synthview opened this issue Feb 19, 2021 · 2 comments
Open

Kerncrash current glyph error on G3. #217

synthview opened this issue Feb 19, 2021 · 2 comments
Assignees

Comments

@synthview
Copy link

Error and no message in Macro window.

Screenshot 2021-02-19 at 17 35 29

@mekkablue
Copy link
Owner

mekkablue commented Feb 23, 2021

@RafalBuchner:

  • abstract more common functions between Kern Crasher and Kern Crash Current Glyph, put them in a separate kernanalysis.py
  • make sure kernanalysis.py is imported and used in both
  • with enough abstraction, consider adding the (Glyphs 3) RTL option that is mentioned as todo in the code. I guess it should query the current state of the edit view (LTR vs RTL), and act accordingly.

I believe currently the functions are a mess. Some of them are local and should be in kernanalysis.py so they can be shared and maintained between both scripts, and some are in both places. The Kern Crasher script is the way it should work, so it should be the reference for both.

@mekkablue
Copy link
Owner

@synthview: This may take a while to sort out. Workaround is to use the main Kern Crasher script with appropriate settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants