From d62cd8a0331b44a3f316d734be50a49fa8c200a1 Mon Sep 17 00:00:00 2001
From: Zhenhua Li <zhenhuali@google.com>
Date: Thu, 21 Mar 2024 11:29:50 -0700
Subject: [PATCH] Change ItemType to object (#10249)

---
 mmv1/api/type.go                          |  2 +-
 mmv1/products/datafusion/go_instance.yaml | 35 ++++++++++++-----------
 mmv1/products/pubsub/go_Topic.yaml        |  3 +-
 3 files changed, 21 insertions(+), 19 deletions(-)

diff --git a/mmv1/api/type.go b/mmv1/api/type.go
index 43afc0f77f8b..df9ab2c3e161 100644
--- a/mmv1/api/type.go
+++ b/mmv1/api/type.go
@@ -135,7 +135,7 @@ type Type struct {
 
 	EnumValues []string `yaml:"enum_values"`
 
-	ItemType string `yaml:"item_type"`
+	ItemType *Type `yaml:"item_type"`
 
 	Resource string
 
diff --git a/mmv1/products/datafusion/go_instance.yaml b/mmv1/products/datafusion/go_instance.yaml
index 729cf2079292..838891f4643b 100644
--- a/mmv1/products/datafusion/go_instance.yaml
+++ b/mmv1/products/datafusion/go_instance.yaml
@@ -279,20 +279,21 @@ able to access the public internet."
 
 If accelerators are enabled it is possible a permadiff will be created with the Options field.
 Users will need to either manually update their state file to include these diffed options, or include the field in a [lifecycle ignore changes block](https://developer.hashicorp.com/terraform/language/meta-arguments/lifecycle#ignore_changes)."
-    item_type: NestedObject
-    properties:
-      - name: 'acceleratorType'
-        type: Enum
-        description: "The type of an accelator for a CDF instance."
-        required: true
-        enum_values:
-          - 'CDC'
-          - 'HEALTHCARE'
-          - 'CCAI_INSIGHTS'
-      - name: 'state'
-        type: Enum
-        description: "The type of an accelator for a CDF instance."
-        required: true
-        enum_values:
-          - 'ENABLED'
-          - 'DISABLED'
+    item_type:
+      properties:
+        - name: 'acceleratorType'
+          type: Enum
+          description: "The type of an accelator for a CDF instance."
+          required: true
+          enum_values:
+            - 'CDC'
+            - 'HEALTHCARE'
+            - 'CCAI_INSIGHTS'
+        - name: 'state'
+          type: Enum
+          description: "The type of an accelator for a CDF instance."
+          required: true
+          enum_values:
+            - 'ENABLED'
+            - 'DISABLED'
+      type: NestedObject
diff --git a/mmv1/products/pubsub/go_Topic.yaml b/mmv1/products/pubsub/go_Topic.yaml
index 17cddf8c9ea7..aec7c9790c33 100644
--- a/mmv1/products/pubsub/go_Topic.yaml
+++ b/mmv1/products/pubsub/go_Topic.yaml
@@ -116,7 +116,8 @@ constraints are in effect."
     allowed regions. An empty list means that no regions are allowed,
     and is not a valid configuration."
         required: true
-        item_type: Api::Type::String
+        item_type:
+          type: String
   - name: 'schemaSettings'
     type: NestedObject
     description: "Settings for validating messages published against a schema."