Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROMs not loadable from non-ASCII file paths #1959

Closed
lesserkuma opened this issue Jan 21, 2024 · 5 comments
Closed

ROMs not loadable from non-ASCII file paths #1959

lesserkuma opened this issue Jan 21, 2024 · 5 comments

Comments

@lesserkuma
Copy link

lesserkuma commented Jan 21, 2024

System used:
Windows 11 23H2

Build used:
https://github.com/melonDS-emu/melonDS/actions/runs/7586469528

Problem:
Can't load ROMs from a path including characters that are not native to the operating system language.

Steps to reproduce:

  1. Rename a confirmed working ROM file to something like あああ.nds, or copy it into a directory path with such non-ASCII characters.
  2. Try to load it with melonDS via any means (File → Open ROM..., Drag & Drop, or Command Line).
  3. Error message "Failed to load the ROM." appears.
@RSDuck
Copy link
Member

RSDuck commented Jan 21, 2024

was already fixed a few days after 0.9.5 release. See #1556

@lesserkuma
Copy link
Author

Ah thanks! I couldn't find it via search.

I tested it on this build btw., should the fix not be implemented into it?
https://github.com/melonDS-emu/melonDS/actions/runs/7586469528

@RSDuck
Copy link
Member

RSDuck commented Jan 21, 2024

yes

@lesserkuma
Copy link
Author

Hmm, the issue is definitely still there with this build from January 19th, 2024. Or it's a different issue, I'm not sure.

@RSDuck
Copy link
Member

RSDuck commented Jan 21, 2024

looks like it is a regression. I just tested it and it used to work.

@RSDuck RSDuck closed this as completed in 18d1df6 Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants