Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wild Pokemon Flash Instead of Fade In #2134

Open
KirsVantas opened this issue Aug 15, 2024 · 8 comments
Open

Wild Pokemon Flash Instead of Fade In #2134

KirsVantas opened this issue Aug 15, 2024 · 8 comments
Labels
timing Timing issue

Comments

@KirsVantas
Copy link

In Pokemon Black/White, wild Pokemon appear in full brightness before flashing at the start of the battle, instead of fading in like on console. I recorded the incorrect effect in MelonDS and have attached it, it can be found here. My video settings have also been attached and can be found here. I have verified it happens both when using OpenGL and when using Software Rendering.
I am using MelonDS 0.9.5

@RSDuck
Copy link
Member

RSDuck commented Aug 15, 2024

Real DSes screens have a very slow response time compared to pretty much every display these days. Thus a flickering like this is often used as an easy way to create transparency.

@KirsVantas
Copy link
Author

KirsVantas commented Aug 15, 2024

Its not flickering, it starts not faded at all, then fades in quickly once.
EDIT: Also, other fades on Pokemon, like the white fade when catching one, works correctly

@Jaklyy
Copy link
Contributor

Jaklyy commented Aug 15, 2024

that is weird
good catch
weirdly enough the effect works properly in black 2
i wonder what's up

@Jaklyy
Copy link
Contributor

Jaklyy commented Aug 17, 2024

The effect is done via updating texture palettes.
The game is just loading the wrong initial palette for no clear reason.
That's gonna be fun to debug.

@Jaklyy
Copy link
Contributor

Jaklyy commented Aug 17, 2024

So the game actually loads the correct (darkened) palette first, and then one frame later loads the wrong (bright) one for... some reason?

@RSDuck
Copy link
Member

RSDuck commented Aug 17, 2024

could it be an issue with rasteriser timing?

EDIT: melonDS currently only synchronises the palette in one spot. Mid frame palette changes would not be immediately applied.

@Jaklyy
Copy link
Contributor

Jaklyy commented Aug 17, 2024

no i dont think that's the issue.
the palette updates happen well before anything is rendered, including on safe vcounts

@Jaklyy
Copy link
Contributor

Jaklyy commented Aug 17, 2024

update: its a timing bug.

@RSDuck RSDuck added the timing Timing issue label Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
timing Timing issue
Projects
None yet
Development

No branches or pull requests

3 participants