From 5734e694994562830a5f7d4894910f2a41ec5aac Mon Sep 17 00:00:00 2001 From: Vitor Avancini Date: Wed, 14 Feb 2024 15:04:47 -0300 Subject: [PATCH] fix(taps): Hard and soft deletes for handling `ACTIVATE_VERSION` messages now use the same `WHERE` clause (#2242) fix: using same logic for both hard and soft deletes Soft delete is deleting only versions smaller than the latest version Hard delete is deleting smaller and equal. Making both strategies delete only smaller versions. --- singer_sdk/connectors/sql.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/singer_sdk/connectors/sql.py b/singer_sdk/connectors/sql.py index e097a4ce9..d3cb01b91 100644 --- a/singer_sdk/connectors/sql.py +++ b/singer_sdk/connectors/sql.py @@ -1212,6 +1212,6 @@ def delete_old_versions( conn.execute( sa.text( f"DELETE FROM {full_table_name} " # noqa: S608 - f"WHERE {version_column_name} <= {current_version}", + f"WHERE {version_column_name} < {current_version}", ), )