From 6f39c03717245525d2f7764cda5310e516fd65aa Mon Sep 17 00:00:00 2001 From: Matthew Will Date: Tue, 30 Jan 2024 14:40:49 -0600 Subject: [PATCH] Mattwill09 patch 1 (#1) * Update sql.py * Update test_target_sqlite.py --- singer_sdk/sinks/sql.py | 3 ++- tests/samples/test_target_sqlite.py | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/singer_sdk/sinks/sql.py b/singer_sdk/sinks/sql.py index 29563d0cb..15b933e3e 100644 --- a/singer_sdk/sinks/sql.py +++ b/singer_sdk/sinks/sql.py @@ -10,6 +10,7 @@ import sqlalchemy as sa from pendulum import now +from sqlalchemy.sql import quoted_name from sqlalchemy.sql.expression import bindparam from singer_sdk.connectors import SQLConnector @@ -282,7 +283,7 @@ def generate_insert_statement( statement = dedent( f"""\ INSERT INTO {full_table_name} - ({", ".join([f'"{name}"' for name in property_names])}) + ({", ".join(quoted_name(name) for name in property_names)}) VALUES ({", ".join([f":{name}" for name in property_names])}) """, # noqa: S608 ) diff --git a/tests/samples/test_target_sqlite.py b/tests/samples/test_target_sqlite.py index 0d34c60a1..f56ad1211 100644 --- a/tests/samples/test_target_sqlite.py +++ b/tests/samples/test_target_sqlite.py @@ -490,7 +490,7 @@ def test_record_with_missing_properties( dedent( """\ INSERT INTO test_stream - (id, name) + ("id", "name") VALUES (:id, :name)""", ), ),