Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve failure in _increment_stream_state() for cases when replication_method is LOG_BASED #1126

Conversation

aaronsteers
Copy link
Contributor

@aaronsteers aaronsteers commented Oct 28, 2022

I did not add any extra tests.

Would be good to pick those up and add official handling for LOG_BASED incremental at the same time.

Reviewing with whitespace changes hidden will help to highlight changed lines.

While creating this PR, I remembered that get_context_state() is not a no-op, so I added a comment to help future maintainers.


📚 Documentation preview 📚: https://meltano-sdk--1126.org.readthedocs.build/en/1126/

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #1126 (4f98e29) into main (81ec6ac) will increase coverage by 0.02%.
The diff coverage is 42.85%.

❗ Current head 4f98e29 differs from pull request most recent head 2310063. Consider uploading reports for the commit 2310063 to get more accurate results

@@            Coverage Diff             @@
##             main    #1126      +/-   ##
==========================================
+ Coverage   83.47%   83.49%   +0.02%     
==========================================
  Files          42       42              
  Lines        3855     3854       -1     
  Branches      658      657       -1     
==========================================
  Hits         3218     3218              
  Misses        472      472              
+ Partials      165      164       -1     
Impacted Files Coverage Δ
singer_sdk/streams/core.py 85.50% <42.85%> (+0.20%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aaronsteers
Copy link
Contributor Author

Codecov CI failure is basically same as before; no increase or decrease per se.

@aaronsteers aaronsteers merged commit 2ae8394 into main Nov 1, 2022
@aaronsteers aaronsteers deleted the 1121-bug-replication-key-should-not-be-required-for-log-based-method branch November 1, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: replication key should not be required for log based method
2 participants