Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(taps): Change max record age for emitting state messages to 5 instead of 30 mins #1192

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

spacecowboy
Copy link
Contributor

@spacecowboy spacecowboy commented Nov 16, 2022

Fixes #1064


📚 Documentation preview 📚: https://meltano-sdk--1192.org.readthedocs.build/en/1192/

@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Merging #1192 (0e46d47) into main (c27b3d7) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1192   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          42       42           
  Lines        3881     3881           
  Branches      659      659           
=======================================
  Hits         3243     3243           
  Misses        474      474           
  Partials      164      164           
Impacted Files Coverage Δ
singer_sdk/target_base.py 86.44% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title Updated max record age to 5 instead of 30 mins fix(taps): Change max record age for emitting state to 5 instead of 30 mins Nov 16, 2022
@edgarrmondragon edgarrmondragon changed the title fix(taps): Change max record age for emitting state to 5 instead of 30 mins fix(taps): Change max record age for emitting state messages to 5 instead of 30 mins Nov 16, 2022
Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@edgarrmondragon edgarrmondragon merged commit 61ed7b4 into meltano:main Nov 16, 2022
@spacecowboy spacecowboy deleted the spacecowboy-max-batch-age branch November 17, 2022 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: If one stream has an error, then all streams fail and no STATE messages are ever sent
3 participants