Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Duplicate required properties in ObjectType/PropertiesList produce required array with duplicate entries #1210

Closed
edgarrmondragon opened this issue Nov 21, 2022 · 0 comments · Fixed by #1214
Labels
kind/Bug Something isn't working valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Nov 21, 2022

Singer SDK Version

0.14.0

Python Version

NA

Bug scope

Configuration (settings parsing, validation, etc.)

Operating System

NA

Description

The following

ObjectType(
    Property("email", StringType, required=True),
    Property("email", StringType, required=True),
    Property("username", StringType, required=True),
)

results in the schema

{
  "type": "object",
  "properties": {
    "email": {
      "type": [
        "string"
      ]
    },
    "username": {
      "type": [
        "string"
      ]
    },
  },
  "required": [
    "email",
    "email",
    "username"
  ]
}

Code

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/Bug Something isn't working valuestream/SDK
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant