fix: Add level and logger name to default log format #1233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1233 +/- ##
=======================================
Coverage 83.72% 83.72%
=======================================
Files 42 42
Lines 3909 3909
Branches 665 665
=======================================
Hits 3273 3273
Misses 473 473
Partials 163 163 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
requested review from
cjohnhanson and
aaronsteers
as code owners
edgarrmondragon
force-pushed
the
1232-bug-default-log-format-is-lacking-details
branch
from
3af9301
to
eb2cd8c
Compare
aaronsteers
approved these changes
Dec 3, 2022
aaronsteers
approved these changes
Dec 3, 2022
- Ensure log level for <tap> logger is only forced when `LOGLEVEL` env var is set - Document log format default
edgarrmondragon
deleted the
1232-bug-default-log-format-is-lacking-details
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1232
📚 Documentation preview 📚: https://meltano-sdk--1233.org.readthedocs.build/en/1233/