fix(templates): Tap template: fix style and docstrings, and add test cases for SQL and "Other" sources #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tap_sql_custom/tap.py:8:1: F401 'tap_sql_custom.client.AutomaticTestTapStream' imported but unused tap_sql_custom/client.py:16:1: DAR101 Missing parameter(s) in Docstring: - config tap_sql_custom/client.py:16:1: DAR201 Missing "Returns" in Docstring: - return tap_sql_custom/client.py:29:1: DAR201 Missing "Returns" in Docstring: - return tap_sql_custom/client.py:29:1: DAR101 Missing parameter(s) in Docstring: - sql_type tap_sql_custom/client.py:40:1: DAR101 Missing parameter(s) in Docstring: - jsonschema_type tap_sql_custom/client.py:40:1: DAR201 Missing "Returns" in Docstring: - return tap_sql_custom/client.py:54:38: F821 undefined name 'Optional' tap_sql_custom/client.py:54:57: F821 undefined name 'Iterable' tap_sql_custom/client.py:54:66: F821 undefined name 'Dict' tap_sql_custom/client.py:54:76: F821 undefined name 'Any'
…to_jsonschema_type)
Codecov Report
@@ Coverage Diff @@
## main #1434 +/- ##
=======================================
Coverage 85.47% 85.47%
=======================================
Files 57 57
Lines 4763 4763
Branches 808 808
=======================================
Hits 4071 4071
Misses 501 501
Partials 191 191 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
flexponsive
changed the title
flexponsive
requested review from
a team,
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
|
Thanks for the PR @flexponsive - looks like we've got some engineers on it as reviewers 👍 |
There was a problem hiding this comment.
@flexponsive should we add these new cases to the GitHub workflow file?
|
@edgarrmondragon good catch! thanks for pointing it out. added the missing cases |
edgarrmondragon
changed the title
edgarrmondragon
approved these changes
Feb 21, 2023
|
thanks @flexponsive! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #1410: Now all tap templates are covered by e2e tests
📚 Documentation preview 📚: https://meltano-sdk--1434.org.readthedocs.build/en/1434/