Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cookiecutter bearer auth config #1454

Merged
merged 2 commits into from
Feb 23, 2023

Conversation

radbrt
Copy link
Contributor

@radbrt radbrt commented Feb 23, 2023

Change config key for bearer auth for REST APIs so that it is consistent across files and works out of the box.

Closes #1452


📚 Documentation preview 📚: https://meltano-sdk--1454.org.readthedocs.build/en/1454/

@radbrt radbrt changed the title Cookiecutter bearer auth config fix: Cookiecutter bearer auth config Feb 23, 2023
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1454 (44eb652) into main (ceb8749) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1454   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files          57       57           
  Lines        4763     4763           
  Branches      808      808           
=======================================
  Hits         4071     4071           
  Misses        501      501           
  Partials      191      191           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@edgarrmondragon edgarrmondragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @radbrt!

@edgarrmondragon edgarrmondragon merged commit 1a79462 into meltano:main Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inconsistent config naming in cookiecutter
2 participants