fix: Use pipx to run tox in CI template #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillDaSilva
requested review from
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1482 +/- ##
=======================================
Coverage 85.46% 85.46%
=======================================
Files 57 57
Lines 4760 4760
Branches 809 809
=======================================
Hits 4068 4068
Misses 501 501
Partials 191 191 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
approved these changes
Mar 6, 2023
|
Thanks for doing this @WillDaSilva! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus some related cleanup. Poetry still needs to be installed before running
pipx run tox ...because tox is configured to use poetry from the external environment, rather than installing it into the tox venv.Supersedes:
Closes #1481
📚 Documentation preview 📚: https://meltano-sdk--1482.org.readthedocs.build/en/1482/