-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(templates): Update cookiecutter tests path #1587
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pnadolny13
requested review from
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
April 6, 2023 20:19
Codecov Report
@@ Coverage Diff @@
## main #1587 +/- ##
=======================================
Coverage 86.18% 86.18%
=======================================
Files 58 58
Lines 4747 4747
Branches 797 797
=======================================
Hits 4091 4091
Misses 465 465
Partials 191 191 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
changed the title
fix: update cookiecutter tests path
fix: Update cookiecutter tests path
Apr 10, 2023
edgarrmondragon
requested changes
Apr 10, 2023
cookiecutter/target-template/{{cookiecutter.target_id}}/tox.ini
Outdated
Show resolved
Hide resolved
edgarrmondragon
approved these changes
Apr 10, 2023
edgarrmondragon
changed the title
fix: Update cookiecutter tests path
fix(templates): Update cookiecutter tests path
Apr 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like these paths weren't updated following #1380. The tests are at the top level now but mypy is looking to exclude them from the subdirectory.
📚 Documentation preview 📚: https://meltano-sdk--1587.org.readthedocs.build/en/1587/