Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow skipping child streams by returning an empty child context from parent stream #1601

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Apr 11, 2023

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #1601 (32fb526) into main (21d0a14) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1601   +/-   ##
=======================================
  Coverage   86.18%   86.18%           
=======================================
  Files          58       58           
  Lines        4747     4750    +3     
  Branches      797      798    +1     
=======================================
+ Hits         4091     4094    +3     
  Misses        465      465           
  Partials      191      191           
Impacted Files Coverage Δ
singer_sdk/streams/core.py 85.18% <100.00%> (+0.10%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@aaronsteers aaronsteers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! 🚀

@edgarrmondragon edgarrmondragon merged commit 5ef52e2 into main Apr 12, 2023
@edgarrmondragon edgarrmondragon deleted the 1597-feat-allow-skipping-child-streams-by-returning-an-empty-child-context-from-parent-stream branch April 12, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Allow skipping child streams by returning an empty child context from parent stream
2 participants