fix(templates): Use get_new_paginator in REST tap cookiecutter template
#1646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report
@@ Coverage Diff @@
## main #1646 +/- ##
=======================================
Coverage 85.05% 85.05%
=======================================
Files 58 58
Lines 4845 4845
Branches 805 805
=======================================
Hits 4121 4121
Misses 526 526
Partials 198 198 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…to-deprecated-get_next_page_token
…to-deprecated-get_next_page_token
…to-deprecated-get_next_page_token
…to-deprecated-get_next_page_token
edgarrmondragon
deleted the
1622-bug-cookiecutter-tap-template-defaults-to-deprecated-get_next_page_token
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing a few recent implementations and they're still using the legacy method, so decided to see if I can tackle this in a short timebox.
Closes #1622
📚 Documentation preview 📚: https://meltano-sdk--1646.org.readthedocs.build/en/1646/