Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): Add email field and use human-readable questions in templates #1905

Merged
merged 2 commits into from
Aug 16, 2023

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 10, 2023

Minor improvements spotted after using the tap template to test #1894:


📚 Documentation preview 📚: https://meltano-sdk--1905.org.readthedocs.build/en/1905/

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1905 (d5cde7f) into main (59c3e3d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1905   +/-   ##
=======================================
  Coverage   86.94%   86.94%           
=======================================
  Files          59       59           
  Lines        5080     5080           
  Branches      822      822           
=======================================
  Hits         4417     4417           
  Misses        466      466           
  Partials      197      197           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 10, 2023 23:42
@edgarrmondragon edgarrmondragon requested review from a team and kgpayne as code owners August 10, 2023 23:42
@edgarrmondragon edgarrmondragon merged commit 1f62ae4 into main Aug 16, 2023
26 checks passed
@edgarrmondragon edgarrmondragon deleted the templates-human-readable-prompts branch August 16, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants