refactor(taps): Use CursorResult.mappings() in SQL streams
#2095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #2095 will not alter performanceComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2095 +/- ##
=======================================
Coverage 87.72% 87.72%
=======================================
Files 60 60
Lines 4946 4946
Branches 1007 1007
=======================================
Hits 4339 4339
Misses 425 425
Partials 182 182 ☔ View full report in Codecov by Sentry. |
edgarrmondragon
added a commit
to MeltanoLabs/tap-postgres
that referenced
this pull request
Dec 12, 2023
~This was fixed upstream in meltano/sdk#1487, but this tap overrides `get_records`.~ I think meltano/sdk#2094 is the only difference between the two implementations? UPDATE: Using the private `._mapping` attribute makes me nervous so I opened meltano/sdk#2095 and updated this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://meltano-sdk--2095.org.readthedocs.build/en/2095/