Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(targets): Log sink name when an unhandled error occurs during setup #2108

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Dec 16, 2023

Copy link

codspeed-hq bot commented Dec 16, 2023

CodSpeed Performance Report

Merging #2108 will not alter performance

Comparing edgarrmondragon/fix/log-sink-name-unhandled-errors (dd5c531) with main (634a2cc)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (634a2cc) 88.03% compared to head (8935dca) 88.02%.

❗ Current head 8935dca differs from pull request most recent head dd5c531. Consider uploading reports for the commit dd5c531 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2108      +/-   ##
==========================================
- Coverage   88.03%   88.02%   -0.02%     
==========================================
  Files          60       60              
  Lines        5007     5002       -5     
  Branches     1014     1014              
==========================================
- Hits         4408     4403       -5     
  Misses        423      423              
  Partials      176      176              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/log-sink-name-unhandled-errors branch 4 times, most recently from 69948a3 to ba8cfc0 Compare December 18, 2023 17:25
@edgarrmondragon edgarrmondragon changed the title fix(targets): Log sink when an unhandled error occurs during setup fix(targets): Log sink name when an unhandled error occurs during setup Dec 19, 2023
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/log-sink-name-unhandled-errors branch 2 times, most recently from d90509c to 34f77ed Compare December 21, 2023 01:37
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/log-sink-name-unhandled-errors branch 2 times, most recently from 0e39561 to 2844b42 Compare January 11, 2024 15:08
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/log-sink-name-unhandled-errors branch 3 times, most recently from 17cc166 to 8935dca Compare January 19, 2024 00:27
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/fix/log-sink-name-unhandled-errors branch from 8935dca to dd5c531 Compare January 19, 2024 01:18
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 19, 2024 01:37
@edgarrmondragon edgarrmondragon merged commit 2fd5164 into main Jan 19, 2024
33 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/log-sink-name-unhandled-errors branch January 19, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant