Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(targets): Allow users to disable schema validation in targets #2208

Merged
merged 1 commit into from
Jan 31, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jan 31, 2024

Copy link

codspeed-hq bot commented Jan 31, 2024

CodSpeed Performance Report

Merging #2208 will not alter performance

Comparing edgarrmondragon/feat/setting-validate-schema (cd19613) with main (32f3dec)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/setting-validate-schema branch from f1189ca to 9e5889c Compare January 31, 2024 19:37
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (32f3dec) 88.46% compared to head (cd19613) 88.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2208      +/-   ##
==========================================
+ Coverage   88.46%   88.47%   +0.01%     
==========================================
  Files          54       54              
  Lines        4716     4722       +6     
  Branches      917      919       +2     
==========================================
+ Hits         4172     4178       +6     
  Misses        383      383              
  Partials      161      161              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/setting-validate-schema branch from 9e5889c to cd19613 Compare January 31, 2024 19:40
@edgarrmondragon edgarrmondragon marked this pull request as ready for review January 31, 2024 19:45
@edgarrmondragon edgarrmondragon merged commit 631d5df into main Jan 31, 2024
32 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/setting-validate-schema branch January 31, 2024 19:52
@anden-akkio
Copy link

anden-akkio commented Feb 15, 2024

Imagine our surprise when we're figuring out how to do this and it turns out you guys merged something two weeks ago! Appreciate the implementation @edgarrmondragon and team, keep up the great work!

Context -- our use case is that we'd rather go through with an import even if the data doesn't match up perfectly with the schema, as we have downstream things that let our users clean up their data, making it often still a salvageable circumstance. We'd rather get an imperfect import than the import not going through at all! We also like fast imports and avoiding validation gets us out of a lot of CPU cycles :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Option to disable schema validation in targets
2 participants