Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use and recommend new pip and poetry versions with support for editable installs #237

Closed
MeltyBot opened this issue Oct 14, 2021 · 1 comment

Comments

@MeltyBot
Copy link
Contributor

Migrated from GitLab: https://gitlab.com/meltano/sdk/-/issues/238

Originally created by @edgarrmondragon on 2021-10-14 16:43:36


During development, Meltano plugin's pip_url lets users pass arguments for an editable installation (-e path/to/package). This is useful for iterating on the tap/target while testing with Meltano.

At the moment, plugins built with the SDK have to [hack their way around to accomplish the same thing](https://gitlab.com/meltano/sdk/-/blob/main/cookiecutter/tap-template/'Reference to deleted milestone 7'B%7Bcookiecutter.tap_id%7D%7D/'Reference to deleted milestone 7'B%7Bcookiecutter.tap_id%7D%7D.sh) because pip was not able to install packages that use pyproject.toml instead of setup.py.

However, recently released pip 21.3 has support for PEP 660. The only blocker is that the PEP 517 build backend needs to implement the build_editable hook.

The poetry-core build backend is PEP 517 compliant and has recently pushed the hook to master (see PR: python-poetry/poetry-core#182). Once this feature is released and indirectly included in the main poetry package, we'll be able to guide users into upgrading their pip and poetry version so they can install their SDK-based plugins in editable mode without hacks.

cc @aaronsteers

@MeltyBot
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants