Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Emit target metrics #2486

Merged
merged 10 commits into from
Aug 13, 2024
Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jun 18, 2024

Closes #1573


📚 Documentation preview 📚: https://meltano-sdk--2486.org.readthedocs.build/en/2486/

@edgarrmondragon edgarrmondragon linked an issue Jun 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.70%. Comparing base (64f9e64) to head (8ed29f0).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2486      +/-   ##
==========================================
+ Coverage   89.69%   89.70%   +0.01%     
==========================================
  Files          58       58              
  Lines        4831     4848      +17     
  Branches      944      947       +3     
==========================================
+ Hits         4333     4349      +16     
- Misses        347      349       +2     
+ Partials      151      150       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented Jun 18, 2024

CodSpeed Performance Report

Merging #2486 will not alter performance

Comparing 1573-feat-compute-target-metrics (8ed29f0) with main (64f9e64)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the 1573-feat-compute-target-metrics branch from 94a642b to 89b8a8a Compare June 18, 2024 15:37
@edgarrmondragon edgarrmondragon force-pushed the 1573-feat-compute-target-metrics branch 2 times, most recently from 32df793 to e4c8e37 Compare June 19, 2024 15:48
@edgarrmondragon edgarrmondragon force-pushed the 1573-feat-compute-target-metrics branch 2 times, most recently from 6ddd94e to 747fd45 Compare July 2, 2024 20:16
@edgarrmondragon edgarrmondragon added this to the v0.40.0 milestone Aug 6, 2024
@edgarrmondragon edgarrmondragon force-pushed the 1573-feat-compute-target-metrics branch from 747fd45 to 9bf4758 Compare August 6, 2024 15:09
@edgarrmondragon edgarrmondragon force-pushed the 1573-feat-compute-target-metrics branch from eb704a3 to 69d599c Compare August 6, 2024 17:10
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 13, 2024 20:48
@edgarrmondragon edgarrmondragon requested review from a team as code owners August 13, 2024 20:48
@edgarrmondragon edgarrmondragon merged commit b6fa56a into main Aug 13, 2024
33 checks passed
@edgarrmondragon edgarrmondragon deleted the 1573-feat-compute-target-metrics branch August 13, 2024 20:55
@edgarrmondragon edgarrmondragon added the Release Highlight Call this out in the release notes label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Release Highlight Call this out in the release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

feat: Compute target metrics
1 participant