Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use mapped stream aliases when handling ACTIVATE_VERSION messages in the base target class #2554

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Jul 19, 2024

Closes #1055


📚 Documentation preview 📚: https://meltano-sdk--2554.org.readthedocs.build/en/2554/

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.44%. Comparing base (119a5ec) to head (5db0c23).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2554   +/-   ##
=======================================
  Coverage   89.44%   89.44%           
=======================================
  Files          58       58           
  Lines        4783     4784    +1     
  Branches      933      934    +1     
=======================================
+ Hits         4278     4279    +1     
  Misses        352      352           
  Partials      153      153           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon marked this pull request as ready for review July 19, 2024 21:01
Copy link

codspeed-hq bot commented Jul 19, 2024

CodSpeed Performance Report

Merging #2554 will not alter performance

Comparing edgarrmondragon/fix/target-handle-activate-version (5db0c23) with main (9901d85)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon merged commit 5b4f41a into main Jul 19, 2024
59 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/fix/target-handle-activate-version branch July 19, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Activate version message does not respect stream alias
1 participant