Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle non-ISO times #2591

Open
edgarrmondragon opened this issue Aug 6, 2024 · 1 comment
Open

feat: Handle non-ISO times #2591

edgarrmondragon opened this issue Aug 6, 2024 · 1 comment
Labels
Accepting Pull Requests kind/Feature New feature or request valuestream/SDK

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Aug 6, 2024 •
edited
Loading

Feature scope

Taps (catalog, state, stream maps, tests, etc.)

Description

For example, 8:30:00. This value does not conform to RFC 3339, section 5.6, but we should still handle it correctly.

The SDK does not seem to emit that type of strings for datetime.time types, so they're most likely coming from elsewhere in the ecosystem.

Slack/Linen
@edgarrmondragon edgarrmondragon changed the title feat: Feature non-ISO times feat: Handle non-ISO times Aug 6, 2024
@edgarrmondragon
Copy link
Collaborator Author

Related: transferwise/pipelinewise-tap-mysql#187

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting Pull Requests kind/Feature New feature or request valuestream/SDK
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@edgarrmondragon