Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mismatch between timezone-aware and naive datetimes in start date and bookmarks is now correctly handled #2613

Conversation

Copy link

codspeed-hq bot commented Aug 20, 2024

CodSpeed Performance Report

Merging #2613 will not alter performance

Comparing 2612-bug-tap-crashes-when-start_date-and-replication-value-are-not-both-tz-aware-or-viceversa (cf69c20) with main (162b910)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.71%. Comparing base (162b910) to head (cf69c20).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2613      +/-   ##
==========================================
+ Coverage   89.70%   89.71%   +0.01%     
==========================================
  Files          58       58              
  Lines        4848     4853       +5     
  Branches      947      948       +1     
==========================================
+ Hits         4349     4354       +5     
  Misses        349      349              
  Partials      150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon merged commit 430dd59 into main Aug 20, 2024
37 checks passed
@edgarrmondragon edgarrmondragon deleted the 2612-bug-tap-crashes-when-start_date-and-replication-value-are-not-both-tz-aware-or-viceversa branch August 20, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Tap crashes when start_date and replication value are not both tz-aware or viceversa
1 participant