Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: Remove upper constraint on faker extra #2640

Merged

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 2, 2024

Less maintenance burden on our end. If faker makes a breaking change upstream, we would just catch it CI and make a patch release.


📚 Documentation preview 📚: https://meltano-sdk--2640.org.readthedocs.build/en/2640/

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner September 2, 2024 15:52
Copy link

codspeed-hq bot commented Sep 2, 2024

CodSpeed Performance Report

Merging #2640 will not alter performance

Comparing edgarrmondragon/packaging/remove-upper-limit-faker (1e6209e) with main (2a3d3fa)

Summary

✅ 6 untouched benchmarks

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.67%. Comparing base (3de2b98) to head (1e6209e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2640   +/-   ##
=======================================
  Coverage   89.67%   89.67%           
=======================================
  Files          58       58           
  Lines        4854     4854           
  Branches      950      950           
=======================================
  Hits         4353     4353           
  Misses        350      350           
  Partials      151      151           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon merged commit aaed6c7 into main Sep 2, 2024
35 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/packaging/remove-upper-limit-faker branch September 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant