Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Renamed SQLConnector.type_mapping to SQLConnector.sql_to_jsonschema #2652

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 6, 2024

Copy link

codspeed-hq bot commented Sep 6, 2024

CodSpeed Performance Report

Merging #2652 will not alter performance

Comparing edgarrmondragon/refactor/rename-type-mapping (a5f8c91) with main (7ea1422)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 6, 2024 18:25
@edgarrmondragon edgarrmondragon requested review from a team as code owners September 6, 2024 18:25
@edgarrmondragon edgarrmondragon merged commit ae86c53 into main Sep 6, 2024
35 of 36 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/refactor/rename-type-mapping branch September 6, 2024 18:26
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (7ea1422) to head (a5f8c91).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2652      +/-   ##
==========================================
- Coverage   89.86%   89.82%   -0.05%     
==========================================
  Files          58       58              
  Lines        4884     4884              
  Branches      959      959              
==========================================
- Hits         4389     4387       -2     
- Misses        344      346       +2     
  Partials      151      151              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant