Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Generate documentation for constructor parameters #900

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Aug 9, 2022

@edgarrmondragon edgarrmondragon self-assigned this Aug 9, 2022
@edgarrmondragon edgarrmondragon marked this pull request as ready for review August 9, 2022 22:39
@codecov
Copy link

codecov bot commented Aug 9, 2022

Codecov Report

Merging #900 (5c3fefc) into main (b6aac25) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #900   +/-   ##
=======================================
  Coverage   80.31%   80.31%           
=======================================
  Files          34       34           
  Lines        3413     3413           
  Branches      679      679           
=======================================
  Hits         2741     2741           
  Misses        499      499           
  Partials      173      173           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon changed the title docs: Generate documentation for method parameters docs: Generate documentation for constructor parameters Aug 10, 2022
Copy link
Member

@WillDaSilva WillDaSilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to render both the signatures and the detailed parameter / return value content? If so I think that would be ideal. In either case, this looks good to me.

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner August 11, 2022 00:53
@edgarrmondragon
Copy link
Collaborator Author

Is it possible to render both the signatures and the detailed parameter / return value content? If so I think that would be ideal. In either case, this looks good to me.

@WillDaSilva good idea! I think I've solved that now by explicitly requesting __init__ gets the same treatment as other methods using :special-members: __init__.

@edgarrmondragon edgarrmondragon force-pushed the 899-bug-method-parameters-descriptions-are-not-added-to-generated-autodocs branch from 090b18c to 594c2f3 Compare August 11, 2022 00:59
@WillDaSilva
Copy link
Member

@edgarrmondragon Could you please provide an updated preview link? I'm not sure how you generated it - I don't see any CI actions for it.

@edgarrmondragon
Copy link
Collaborator Author

@edgarrmondragon Could you please provide an updated preview link? I'm not sure how you generated it - I don't see any CI actions for it.

@WillDaSilva It's up-to-date with the changes in this PR. Builds are triggered in readthedocs but it's failing to report back to GitHub in the PR checks.

@edgarrmondragon edgarrmondragon merged commit cc7e06d into main Aug 11, 2022
@edgarrmondragon edgarrmondragon deleted the 899-bug-method-parameters-descriptions-are-not-added-to-generated-autodocs branch August 11, 2022 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Constructor parameters descriptions are not added to generated autodocs
2 participants