feat: add ConnectionError to list of backoff exceptions for auto-retry
#919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlloyd-widen
requested review from
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
Codecov Report
@@ Coverage Diff @@
## main #919 +/- ##
=======================================
Coverage 80.33% 80.33%
=======================================
Files 34 34
Lines 3418 3418
Branches 679 679
=======================================
Hits 2746 2746
Misses 499 499
Partials 173 173
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aaronsteers
changed the title
aaronsteers
changed the title
ConnectionError to list of backoff exceptions for auto-retry
aaronsteers
reviewed
Aug 23, 2022
aaronsteers
approved these changes
Aug 23, 2022
Same! |
edgarrmondragon
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running into an error similar to this on Github. So I decided to address it by adding it to the list of back off exceptions.
This fixed the issue for me.