-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Cloud Storage Backend #61
Comments
Hello, can work on this one ? |
Hello @a-hilaly, of course, go ahead! You can bother me if you need anything. I'd be happy to review your work. We already have interfaces and conventions in place to add a new back-end. You can have a look at https://github.com/meltwater/drone-cache/blob/master/cache/backend/s3.go to kickstart things. |
Nice 👍 ! Thanks for the tip @kakkoyun i'm going to open a PR soon |
I am doing some documentation cleanup, so adding this link here. This issue is about integrating with https://cloud.google.com/storage/ |
@kakkoyun while implementing this backend, i realised that Cloud Storage Go client need a I had toughs about changing the Backend interface to allow context propagation with something like: type Backend interface {
Get(context.Context, string) (io.ReadCloser, error)
Put(context.Context, string, io.ReadSeeker) error
} Anyways this will certainly force changes all over the backends/plugin/main and need to be discussed/implemented in a separate PR. I'm still not sure if context cancellation can be useful at this stage, but i think it can be a great feature, especially when dealing with huge objects. |
@a-hilaly That's a good idea. I'm also a fan of |
Create a new backend implementation to support GCP Object storage
The text was updated successfully, but these errors were encountered: