Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Ability to suggest edits to deck holder #25

Open
Crowbrammer opened this issue Nov 22, 2020 · 3 comments
Open

Feature Request: Ability to suggest edits to deck holder #25

Crowbrammer opened this issue Nov 22, 2020 · 3 comments

Comments

@Crowbrammer
Copy link

For instance:

https://memorize.ai/d/jT6p_r2rkR/web-development-interview-questions

FRONT: "What is variable hoisting in JavaScript? What are the issues that can arise with this?"
BACK: "Variables and functions may be available before they are declared. The javascript [sic] interpreter looks ahead to all variables that are to be declared in a function and hoists them to the top. Problems occur when you have variables of the same name inside and outside of a function."

I tested this:

console.log(derp);
const derp = 16;

And it gave me this:

console.log(derp);
            ^

ReferenceError: Cannot access 'derp' before initialization
    at Object.<anonymous> (C:\Users\Choppy\Documents\Clutter\Coding\practice\hoisting\index.js:1:13)
    at Module._compile (internal/modules/cjs/loader.js:1133:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1153:10)
    at Module.load (internal/modules/cjs/loader.js:977:32)
    at Function.Module._load (internal/modules/cjs/loader.js:877:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:74:12)
    at internal/main/run_main_module.js:18:47

It only semi worked with var, but then it logged undefined.

Hoisting for variables works differently than for functions, and it'd be cool to suggest this to the creator.

@kenmueller
Copy link
Member

I love this idea! This is what I was initially thinking with the chat feature on the deck page, so you can send a message to the owner, but if you think a more dedicated feature is necessary, I'd be more than willing to implement it.

What about a comment section for each card? On the deck page, you'll be able to see comments on the cards, and on the review page, you can also see comments. This way, not only can you suggest ideas, but you can also talk about what's on the card!

@kenmueller
Copy link
Member

In the meantime, I can transfer the deck to you so you can make any necessary changes now or in the future. I just need to know the email you used for your account, you can send it to [email protected].

@Crowbrammer
Copy link
Author

I suppose I could talk with the owner with the chat feature 😮

I think there are two phases to this:

  1. Comments, like you mentioned. If that was there, I for sure would've used that. I'd be happy with that.
  2. Git-style edits, or something like Stack Overflow uses. It's a somewhat big ask, but that's my ideal.

All this said, this app's great. Thanks for making it.

(Email sent 😗)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants