Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command service delete, improve tests #123

Closed
NicolasMahe opened this issue Dec 5, 2018 · 2 comments
Closed

Command service delete, improve tests #123

NicolasMahe opened this issue Dec 5, 2018 · 2 comments

Comments

@NicolasMahe
Copy link
Member

We need to improve the current tests of the command service delete and put back the test written by @ilgooz (mesg-foundation/engine@f75edb7#diff-1e2b189fbe22015837a0f3e008fc6378)

The issue is about how to test survey without introducing a new mock.

Some useful resources:
https://github.com/AlecAivazis/survey/blob/v1.7.0/confirm_test.go#L21
https://github.com/AlecAivazis/survey#testing
@NicolasMahe
Copy link
Member Author

mesg-foundation/engine#613 (comment)

@NicolasMahe NicolasMahe changed the title Command service delete tests Command service delete, improve tests Dec 11, 2018
@krhubert
Copy link
Contributor

@mesg-foundation/core todo: close or move to cli issues

@antho1404 antho1404 transferred this issue from mesg-foundation/engine May 24, 2019
@antho1404 antho1404 transferred this issue from mesg-foundation/cli Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@antho1404 @krhubert @NicolasMahe