service: add Getters and Validate, Require methods for task, event and output #409
Conversation
ilgooz
force-pushed
the
feature/service-getters
branch
from
d0ca943
to
e85f699
Compare
ilgooz
force-pushed
the
feature/service-getters
branch
2 times, most recently
from
54011d6
to
ed224b7
Compare
ilgooz
force-pushed
the
feature/service-getters
branch
from
ed224b7
to
52a52ae
Compare
| string key = 4; // Event's key. | ||
| string name = 1; // Event's name. | ||
| string description = 2; // Event's description. | ||
| string serviceName = 5; // Event's service name. |
There was a problem hiding this comment.
Do you plan to keep serviceName in Event in the future?
If not, how do you plan to access this data in the future from the Event type?
There was a problem hiding this comment.
no i don't. i'll add private service field to Event type.
type Event struct {
service *Service
}
There was a problem hiding this comment.
I really don't like to have the service in the event, we should try to keep things really separated and ask ourselves why we really need the service in the event. If it's just to have the name of the service in one error this can be resolved with a event error that is catch and where the calling function can add the service.
Have a double dependencies between resources always makes things way more complicated in the end
There was a problem hiding this comment.
I understand that this PR is temporary, to be able to have our own structure for service. Just one thing I want to point:
The service.proto is not really needed when we have our own structure because the deployment is done by tar or url and the only api that use service.proto are list and get and they can have their own data, they don't need to send all the service.
resolves #349
resolves #348
related with #337