Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use docker volumes and not binding for services #419

Merged
merged 7 commits into from
Sep 3, 2018

Conversation

antho1404
Copy link
Member

The actual system is using binding for services volumes. In our case we don't really need to bind the folder to a specific path on the host machine and this add a lot of complexity on the configuration of this docker container.

The docker socket sent to the core container is still using the bind mode but other volumes are now using the new default value from docker volume and not bind anymore. This means that all the volumes that need to be mounted on a service will no longer be present in ~/.mesg/services but will be managed by docker.

This will be helpful for the PR #416

fix #125

@antho1404 antho1404 added this to the v1.2.0 milestone Sep 2, 2018
@antho1404 antho1404 requested a review from a team September 2, 2018 09:16
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working well, so I approve.

But, we don't provide any way to delete the volume. I suggest to delete the volume with the API deleteService. I will create an issue.

@NicolasMahe NicolasMahe merged commit 9cb6d20 into dev Sep 3, 2018
@NicolasMahe NicolasMahe deleted the feature/use-docker-volume branch September 3, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Docker volume
3 participants