Store configuration in service as a separated attribute #860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
reviewed
Apr 9, 2019
NicolasMahe
reviewed
Apr 9, 2019
NicolasMahe
reviewed
Apr 9, 2019
NicolasMahe
reviewed
Apr 9, 2019
|
This pull request has been mentioned on MESG Community. There might be relevant details there: https://forum.mesg.com/t/split-default-env-and-users-env/268/1 |
Merged
…undation/core into feature/configuration-in-service
ilgooz
reviewed
Apr 11, 2019
ilgooz
reviewed
Apr 11, 2019
krhubert
approved these changes
Apr 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the configuration from the list of dependencies in the service structure to its own attribute.
This still fallback correctly to previous services (with configuration in the dependencies)
Still few questions: