Marketplace remove hash from manifest #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasMahe
force-pushed
the
ss/marketplace-remove-hash-manifest
branch
from
562729c
to
da21f67
Compare
NicolasMahe
changed the title
NicolasMahe
force-pushed
the
ss/marketplace-remove-hash-manifest
branch
from
3754dc1
to
1f3e041
Compare
|
@mesg-foundation/core I remove the dependency to the other PR. Ready to review. |
|
@NicolasMahe I added a fix commit, it's better to squash this one while merging |
NicolasMahe
force-pushed
the
ss/marketplace-remove-hash-manifest
branch
from
f9cdf00
to
198b711
Compare
Done |
krhubert
reviewed
Apr 17, 2019
ilgooz
previously approved these changes
Apr 18, 2019
antho1404
previously approved these changes
Apr 18, 2019
# Conflicts: # systemservices/marketplace/mesg.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start to implements #861 for CLI and Service Marketplace:
only remove unnecessary hash for now