From 52a52ae9b75b1575643abf0883932aa288374ad9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?I=CC=87lker=20Go=CC=88ktug=CC=86=20O=CC=88ztu=CC=88rk?=
 <ilkergoktugozturk@gmail.com>
Date: Thu, 30 Aug 2018 01:08:35 +0300
Subject: [PATCH] improve comments

---
 event/event.go        | 2 +-
 service/event.go      | 4 ++--
 service/task.go       | 8 ++++----
 service/validation.go | 5 ++++-
 4 files changed, 11 insertions(+), 8 deletions(-)

diff --git a/event/event.go b/event/event.go
index 54f15c0f8..aaf6432b7 100644
--- a/event/event.go
+++ b/event/event.go
@@ -15,7 +15,7 @@ type Event struct {
 	CreatedAt time.Time
 }
 
-// Create creates an event.
+// Create creates an event eventKey with eventData for service s.
 func Create(s *service.Service, eventKey string, eventData map[string]interface{}) (*Event, error) {
 	event, err := s.GetEvent(eventKey)
 	if err != nil {
diff --git a/service/event.go b/service/event.go
index e567ea068..a3c117700 100644
--- a/service/event.go
+++ b/service/event.go
@@ -12,12 +12,12 @@ func (s *Service) GetEvent(eventKey string) (*Event, error) {
 	return event, nil
 }
 
-// ValidateData validates event data to match with paremeter config.
+// ValidateData produces warnings for event datas that doesn't satisfy their parameter schemas.
 func (e *Event) ValidateData(eventData map[string]interface{}) []*ParameterWarning {
 	return validateParametersSchema(e.Data, eventData)
 }
 
-// RequireData requires event data to match with paremeter config.
+// RequireData requires event datas to be matched with parameter schemas.
 func (e *Event) RequireData(eventData map[string]interface{}) error {
 	warnings := e.ValidateData(eventData)
 	if len(warnings) > 0 {
diff --git a/service/task.go b/service/task.go
index 040353014..7e1ce319a 100644
--- a/service/task.go
+++ b/service/task.go
@@ -12,12 +12,12 @@ func (s *Service) GetTask(taskKey string) (*Task, error) {
 	return task, nil
 }
 
-// ValidateInputs validates task inputs to match with paremeter config.
+// ValidateInputs produces warnings for task inputs that doesn't satisfy their parameter schemas.
 func (t *Task) ValidateInputs(taskInputs map[string]interface{}) []*ParameterWarning {
 	return validateParametersSchema(t.Inputs, taskInputs)
 }
 
-// RequireInputs requires task inputs to match with paremeter config.
+// RequireInputs requires task inputs to be matched with parameter schemas.
 func (t *Task) RequireInputs(taskInputs map[string]interface{}) error {
 	warnings := t.ValidateInputs(taskInputs)
 	if len(warnings) > 0 {
@@ -43,12 +43,12 @@ func (t *Task) GetOutput(outputKey string) (*Output, error) {
 	return output, nil
 }
 
-// ValidateData validates task outputs to match with paremeter config.
+// ValidateData produces warnings for task outputs that doesn't satisfy their parameter schemas.
 func (o *Output) ValidateData(outputData map[string]interface{}) []*ParameterWarning {
 	return validateParametersSchema(o.Data, outputData)
 }
 
-// RequireData requires task outputs to match with paremeter config.
+// RequireData requires task outputs to be matched with parameter schemas.
 func (o *Output) RequireData(outputData map[string]interface{}) error {
 	warnings := o.ValidateData(outputData)
 	if len(warnings) > 0 {
diff --git a/service/validation.go b/service/validation.go
index a711e3f67..f82110c3e 100644
--- a/service/validation.go
+++ b/service/validation.go
@@ -32,6 +32,7 @@ func validateParametersSchema(parameters map[string]*Parameter,
 	return warnings
 }
 
+// parameterValidator provides functionalities to check data against its parameter schema.
 type parameterValidator struct {
 	key       string
 	parameter *Parameter
@@ -41,7 +42,7 @@ func newParameterValidator(key string, parameter *Parameter) *parameterValidator
 	return &parameterValidator{key, parameter}
 }
 
-// Validate returns a warning based on the match of the data given in parameter and the parameter.
+// Validate validates value by comparing to its parameter schema.
 func (v *parameterValidator) Validate(value interface{}) *ParameterWarning {
 	if value == nil {
 		if v.parameter.Optional {
@@ -53,6 +54,7 @@ func (v *parameterValidator) Validate(value interface{}) *ParameterWarning {
 	return v.validateType(value)
 }
 
+// validateType checks if value comforts its expected type.
 func (v *parameterValidator) validateType(value interface{}) *ParameterWarning {
 	switch v.parameter.Type {
 	case "String":
@@ -87,6 +89,7 @@ func (v *parameterValidator) validateType(value interface{}) *ParameterWarning {
 	return nil
 }
 
+// newParameterWarning creates a ParameterWarning with given warning message.
 func (v *parameterValidator) newParameterWarning(warning string) *ParameterWarning {
 	return &ParameterWarning{
 		Key:       v.key,