Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Hash.Dump instead of xstructhash or structhash #1093

Closed
3 tasks
NicolasMahe opened this issue Jun 24, 2019 · 0 comments · Fixed by #1098
Closed
3 tasks

Use Hash.Dump instead of xstructhash or structhash #1093

NicolasMahe opened this issue Jun 24, 2019 · 0 comments · Fixed by #1098
Assignees
@krhubert

Comments

@NicolasMahe
Copy link
Member

NicolasMahe commented Jun 24, 2019 •
edited
Loading

  • Function that need to hash a struct should use Hash.Dump instead of xstructhash or structhash (but keep structhash under the hood)
  • xstructhash should be removed
  • Also, it would make sense that the Dump function return Digest instead of Hash, so more data can be added to the Digest. @krhubert what do you think?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@krhubert krhubert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove xstructhash mesg-foundation/engine
2 participants
@krhubert @NicolasMahe