Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add balance system on processes #1698

Closed
NicolasMahe opened this issue Mar 3, 2020 · 2 comments · Fixed by #1699
Closed

Add balance system on processes #1698

NicolasMahe opened this issue Mar 3, 2020 · 2 comments · Fixed by #1699
Labels
enhancement New feature or request

Comments

@NicolasMahe
Copy link
Member

NicolasMahe commented Mar 3, 2020

Processes should have their own balance where

  • any user can put coins using the bank module
  • only the owner of the process can withdraw (related to Handle withdraw from resources #1688)
  • execution linked to a process (processHash is set) should take the coins from the process and NOT from the signer of the transaction
@NicolasMahe
Copy link
Member Author

Open question:
@antho1404 @krhubert Should we force the user to transfer coins to the process on its creation? It could be done in the process module handler. Otherwise, the CLI could create a new transaction that transfers coins to the newly created process.

@antho1404
Copy link
Member

I would recommend to keep it simple for now and we create the process and then execute a transfer to this process.
We can, of course, send a transaction with 2 messages, one to create the process, the other one to add a balance to it.
Ultimately we could have the optional parameter to create and deposit on the process in the same message but I think it will be overkill for now.
Also having a process with no balance is quite nice, I could deploy a process for a company but it's their responsibility to deposit on it and the process will start/work only when they deposit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants