Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors on the listening apis #374

Closed
antho1404 opened this issue Aug 17, 2018 · 1 comment
Closed

Handle errors on the listening apis #374

antho1404 opened this issue Aug 17, 2018 · 1 comment
Assignees
@ilgooz
Labels
bug Something isn't working
Milestone
v1.2.0

Comments

@antho1404
Copy link
Member

Right now we don't handle some errors when marshaling some data

https://github.com/mesg-foundation/core/blob/dev/api/core/listen_event.go#L36

https://github.com/mesg-foundation/core/blob/dev/api/core/listen_result.go#L36

https://github.com/mesg-foundation/core/blob/dev/api/service/listen_task.go#L29
@antho1404 antho1404 added the bug Something isn't working label Aug 17, 2018
@antho1404 antho1404 mentioned this issue Aug 17, 2018
Merged
@antho1404 antho1404 self-assigned this Aug 21, 2018
@antho1404 antho1404 added this to the v1.2.0 milestone Aug 21, 2018
@ilgooz ilgooz mentioned this issue Aug 22, 2018
Merged
@ilgooz ilgooz assigned ilgooz and unassigned antho1404 Aug 22, 2018
@ilgooz
Copy link
Contributor

ilgooz commented Sep 10, 2018

closing this, already fixed by referenced PR.

@ilgooz ilgooz closed this as completed Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilgooz ilgooz

Labels
bug Something isn't working
Projects
None yet
Milestone
v1.2.0
Development

No branches or pull requests
2 participants
@antho1404 @ilgooz