From 308f8b10dceddcd600a468f44c73ce07b8bdef0b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?I=CC=87lker=20Go=CC=88ktug=CC=86=20O=CC=88ztu=CC=88rk?= Date: Wed, 22 Aug 2018 09:07:14 +0300 Subject: [PATCH] TestServiceDependenciesListensFromSamePort test added for service package, related with #380, #371 --- service/start.go | 2 +- service/status_test.go | 31 +++++++++++++++++++++++++++++++ 2 files changed, 32 insertions(+), 1 deletion(-) diff --git a/service/start.go b/service/start.go index 9e47a92c0..7f0a16fa0 100644 --- a/service/start.go +++ b/service/start.go @@ -50,7 +50,7 @@ func (service *Service) Start() (serviceIDs []string, err error) { }(dependency, i) } wg.Wait() - // Grasfully stop the service because there is an error + // Gracefully stop the service because there is an error if err != nil { service.Stop() } diff --git a/service/status_test.go b/service/status_test.go index 41f345273..9e85594bb 100644 --- a/service/status_test.go +++ b/service/status_test.go @@ -88,3 +88,34 @@ func TestListMultipleDependencies(t *testing.T) { require.Equal(t, len(list), 1) require.Equal(t, list[0], hash) } + +func TestServiceDependenciesListensFromSamePort(t *testing.T) { + var ( + service = &Service{ + Name: "TestServiceDependenciesListensFromSamePort", + Dependencies: map[string]*Dependency{ + "test": { + Image: "nginx", + Ports: []string{"80"}, + }, + }, + } + + service1 = &Service{ + Name: "TestServiceDependenciesListensFromSamePort1", + Dependencies: map[string]*Dependency{ + "test": { + Image: "nginx", + Ports: []string{"80"}, + }, + }, + } + ) + _, err := service.Start() + require.NoError(t, err) + defer service.Stop() + + _, err = service1.Start() + require.NotZero(t, err) + require.Contains(t, err.Error(), `port '80' is already in use`) +}