diff --git a/service/importer/service_file.go b/service/importer/service_file.go index bde76cd78..559a394b8 100644 --- a/service/importer/service_file.go +++ b/service/importer/service_file.go @@ -55,6 +55,10 @@ func validateServiceStruct(service *ServiceDefinition) []string { } } + if service.Configuration != nil && service.Configuration.Image != "" { + warnings = append(warnings, "configuration.image is not allowed") + } + for key, dep := range service.Dependencies { if dep == nil { continue diff --git a/service/importer/tests/service-configuration-with-image/mesg.yml b/service/importer/tests/service-configuration-with-image/mesg.yml new file mode 100644 index 000000000..e0ae99fae --- /dev/null +++ b/service/importer/tests/service-configuration-with-image/mesg.yml @@ -0,0 +1,3 @@ +name: "test" +configuration: + image: busybox diff --git a/service/importer/validation_test.go b/service/importer/validation_test.go index 63e4799ea..bc53a554f 100644 --- a/service/importer/validation_test.go +++ b/service/importer/validation_test.go @@ -58,6 +58,12 @@ func TestValidateFromMalFormattedServiceFile(t *testing.T) { require.Len(t, validation.ServiceFileWarnings, 1) } +func TestValidateConfiguratioinImage(t *testing.T) { + validation, err := Validate("./tests/service-configuration-with-image") + require.NoError(t, err) + require.Len(t, validation.ServiceFileWarnings, 1) +} + func TestValidateFromInvalidServiceFile(t *testing.T) { validation, err := Validate("./tests/service-file-invalid") require.NoError(t, err)