Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Golang Test Failure: Compose #447

Open
leecalcote opened this issue Jan 8, 2024 · 5 comments
Open

[Chore] Golang Test Failure: Compose #447

leecalcote opened this issue Jan 8, 2024 · 5 comments
Labels
help wanted Extra attention is needed issue/willfix This issue will be worked on kind/bug Something isn't working language/go Golang related

Comments

@leecalcote
Copy link
Member

leecalcote commented Jan 8, 2024

Description
make go fails with the following error:

# github.com/kubernetes/kompose/pkg/transformer/kubernetes
../go/bin/pkg/mod/github.com/meshery/[email protected]/pkg/transformer/kubernetes/kubernetes.go:583:15: cannot use api.ResourceRequirements{…} (value of type "k8s.io/api/core/v1".ResourceRequirements) as "k8s.io/api/core/v1".VolumeResourceRequirements value in struct literal

Expected Behavior
All go test tests pass.


Contributor Guides and Handbook

@leecalcote leecalcote added help wanted Extra attention is needed issue/willfix This issue will be worked on kind/bug Something isn't working language/go Golang related labels Jan 8, 2024
@MonalikaPatnaik
Copy link

In my machine, running the command make go gives this--
m2c -o go -e go go.mod /bin/bash: line 1: m2c: command not found make: *** [<builtin>: go] Error 127
Could you elaborate the steps to reproduce this error?

@ayushrakesh
Copy link

@leecalcote I am interested to work in this issue.

@leecalcote
Copy link
Member Author

Thanks much for jumping in and volunteering. I missed the prior notifications. Here's what helps guarantee both your success and assignment of the issue (and there are plenty more where this issue comes from):

Confirm that you're able to build the project, specifically, the components necessary to resolve this issue.
Confirm the approach you intend to take to resolve the issue.

@ayushrakesh
Copy link

@leecalcote make go command is not right? Is is make test for running test? If yes, then I am not getting error on my side.

@ayushrakesh
Copy link

@leecalcote I want some more explanation about this issue, please help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed issue/willfix This issue will be worked on kind/bug Something isn't working language/go Golang related
Projects
None yet
Development

No branches or pull requests

3 participants