Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Show unknown nodes' hex IDs instead of "UNK: " followed by their decimal ID #299

Closed
Kealper opened this issue Sep 15, 2024 · 0 comments · Fixed by #304
Labels
enhancement New feature or request minor change This is a minor change parity Feature is in other app (iOS, Android, etc)

Comments

@Kealper
Copy link

Kealper commented Sep 15, 2024

Description

In areas of the web client where nodes are shown (Messages view, Nodes view, and on the Map view), it would be helpful and more consistent with the current mobile apps if any nodes that have not yet had their NodeInfo added to the local node's NodeDB would show as their hexadecimal ID instead of the "raw" one, with their short name just using the last two bytes of their hexadecimal ID until their "real" name and short name are known.

For example: Instead of showing "UNK: 123456789" on the Nodes view, "Unknown" on the Messages view, and a blank string next to their unique "avatar" image on the Map view, it could show "!075bcd15" until it had more information on the node. If a short name needed to be displayed for something, it could simply use "cd15" in that example node's case.

I think this would help with readability in the Messages and Nodes views since it would be easier to differentiate multiple new unknown nodes without relying solely on the unique avatar images, and in the Nodes view specifically, it would help with consistency for figuring out which node is which since the other apps are already converting those raw IDs to hexadecimal before displaying them. On the Map view, it would help because currently, unknown nodes have no displayed name at all, and this would at least give them something until better information is received.

@Kealper Kealper added the enhancement New feature or request label Sep 15, 2024
@Hunter275 Hunter275 added minor change This is a minor change parity Feature is in other app (iOS, Android, etc) labels Sep 15, 2024
@KomelT KomelT mentioned this issue Sep 17, 2024
@KomelT KomelT mentioned this issue Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor change This is a minor change parity Feature is in other app (iOS, Android, etc)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants