Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cargo-bitbake does not honor .cargo/config.toml, and modifies my Cargo.lock #67

Open
jaskij opened this issue May 26, 2023 · 3 comments

Comments

@jaskij
Copy link

jaskij commented May 26, 2023

As in the title - running cargo-bitbake modifies my Cargo.lock, and removes a dependency (valuable-derive).

The issue seems to revolve around honoring the dependency chain tracing-core->valuable->valuable-derive. In tracing the support (and requirement) for valuable depends on a configuration flag (--cfg tracing_unstable). It is set in my $HOME/.cargo/config.toml, but cargo-bitbake seems to not honor it.

I can confirm that manually adding the depenency, either in my Cargo.toml, or in the generated bitbake file, fixes the build.

Overall, this is kind of weird, and raises a few questions:

  • Why is cargo-bitbake modifying Cargo.lock in the first place?
  • Why is cargo-bitbake not honoring my .cargo/config.toml settings?
  • How can this be fixed?
  • Is there any workaround?
@jaskij
Copy link
Author

jaskij commented May 26, 2023

cc @eivindbergem as this may be related to #58 - both revolve around dependency resoluton

@BKDaugherty
Copy link

@jaskij I was also surprised by this, and honestly don't really understand the intended interaction between Cargo.lock files and cargo bitbake. For my private organization, I added a quick flag that just looks at an existing Cargo.lock file and skips resolution. Here's the PR: #71

Might be interesting to you!

@jaskij
Copy link
Author

jaskij commented Aug 31, 2023

@BKDaugherty thanks! That does look interesting. Sadly, I'm already using the version from #70 because of git dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants