Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create EventHandler annotation for Proxy methods #19

Open
lidaamber opened this issue May 26, 2017 · 1 comment
Open

Create EventHandler annotation for Proxy methods #19

lidaamber opened this issue May 26, 2017 · 1 comment

Comments

@lidaamber
Copy link
Member

lidaamber commented May 26, 2017

We should add an @EventHandler annotation for Proxy methods to process incoming events in the way like this:

@EventHandler
void onSomeEvent(List<?> args);
@EventHandler("eventName")
void onSomeEvent(List<?> args);
@EventHandler({"interfaceName", "eventName"})
void onSomeEvent(List<?> args);

With this annotation the generated class for Proxy should be abstract, so that the User'll later implement handlers for methods with @EventHandler annotation.

@lundibundi
Copy link
Member

I implemented this in 29e3ffc but I'm not sure it we should land this functionality as it can be easily achieved using a combination of Proxy and Handler (the implementation just uses Handler functions to create them here).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants