Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Svelte 5 #38

Open
MathiasWP opened this issue Oct 23, 2024 · 4 comments
Open

Support for Svelte 5 #38

MathiasWP opened this issue Oct 23, 2024 · 4 comments

Comments

@MathiasWP
Copy link

Svelte 5 is out, and it would be really nice if this library supported Svelte 5

@metonym
Copy link
Owner

metonym commented Oct 23, 2024

What is the error when using with Svelte 5? IIRC, existing libraries should (mostly) be interop with Svelte 5.

@MathiasWP
Copy link
Author

MathiasWP commented Oct 24, 2024

The component type is different in Svelte 5, so if i have a prop like prefixIcon and set the type to Component then TS will error because the types does not match anymore.

@metonym
Copy link
Owner

metonym commented Oct 24, 2024

Could you provide a quick code snippet that I can repro with? Happy to take a look.

@MathiasWP
Copy link
Author

Thanks for the quick response. Rather than providing a repro, I think it would be more practical to go ahead and create a v4 branch of the library that supports Svelte 5. The Svelte maintainers have advised library authors to start migrating to Svelte 5, and it makes sense to follow that recommendation. The issue here is primarily due to the change in component types, which is causing TypeScript type mismatches. A dedicated Svelte 5 version would help avoid these issues and align with the community's push for compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants