Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to latest prebid.js version #24

Closed
vdias38 opened this issue May 17, 2018 · 5 comments
Closed

Upgrade to latest prebid.js version #24

vdias38 opened this issue May 17, 2018 · 5 comments
Assignees
@danconte72
Milestone
v1.2: GDPR Support

Comments

@vdias38
Copy link
Contributor

vdias38 commented May 17, 2018 •
edited
Loading

Prebid 1.0 Publisher API Changes
incl. same adapters as previous version, but remove piximedia and add consentManagement
@vdias38 vdias38 added this to the v1.2: GDPR Support milestone May 17, 2018
@danconte72
Copy link
Contributor

danconte72 commented May 18, 2018 •
edited
Loading

there is no Criteo module so far

@danconte72
Copy link
Contributor

Checking all API changes we just have to remove pbams.setPriceGranularity('dense');
Replacing by pbams.setConfig({ priceGranularity: 'dense' });

@danconte72
Copy link
Contributor

Criteo PR

@vdias38
Copy link
Contributor Author

vdias38 commented May 22, 2018

bidders are not launched, I'm not sure you are following v1.x specifications, please check AdUnit reference.

@vdias38 vdias38 reopened this May 22, 2018
@vdias38
Copy link
Contributor Author

vdias38 commented May 22, 2018

provide on issue the command you've used to build your prebid version. If criteo is missing provide the command and error message raised.
The more accurate you are the more understandable/readable you'll be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danconte72 danconte72

Labels
None yet
Projects
None yet
Milestone
v1.2: GDPR Support
Development

No branches or pull requests
2 participants
@vdias38 @danconte72