Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix and improvement in RectangleObject getWidth() and getHeight() #40

Open
etienned opened this issue Feb 24, 2012 · 0 comments
Open

Comments

@etienned
Copy link

In generic.py on line 727, it's like that:

def getHeight(self):
    return self.getUpperRight_y() - self.getLowerLeft_x()

And should be like that (the "x" change to "y" at the end):

def getHeight(self):
    return self.getUpperRight_y() - self.getLowerLeft_y()

Also both getWidth() and getHeight() output should be wrap in abs() like that:

def getHeight(self):
    return abs(self.getUpperRight_y() - self.getLowerLeft_y())

And we could add properties to make the thing more pleasant:

@property
def width(self):
    return self.getWidth()

@property
def height(self):
    return self.getHeight()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant